supports_legacy should be a property of the emulator, not an argument to the test case. See supports_taproot.

Okay, we can use this convention. I'll updating that shortly, but then I will also add the relevant field to the other emulators.

It should be fine to just change the address type to sh_wit always instead of using legacy for the other devices.

Okay, changed the types to sh_wit

This script needs to work when run inside a docker container as that is how the tests are suggested to be run locally. IIRC Docker within docker doesn't really work, so I don't think this will.

Replace with

cd bitbox02-firmware
make dockerpull

(remove the cd below then)

use $(cat .containerversion) instead of latest here too

Isn't there a way to build it without docker?

Not really, this is how we build and release the BB02 firmware. Replicating the Docker environment outside of it is bound to lead to tons of overhead in maintenance and CI breaks.

podman instead of docker would also work though.

Ok, anyway, I could build and run it. No problem.

I had some problems with this test. It seems it should pass bitcoind and interface in bitbox02_test_suite instead of None, no?

Yes, you're right. Fixed that now.

Got this error running setup_environment.sh:

+ docker run -i --rm --volume ./:/bb02 shiftcrypto/firmware_v2:42 bash -c 'git config --global --add safe.directory /bb02 && cd /bb02 && make -j simulator'
docker: Error response from daemon: create ./: "./" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.

I think you could use "$(pwd):/bb02" instead of ./:/bb02.

This was not an issue in CI, but in local maybe that created problems. Anyways, I changed to $(pwd) instead of . as you suggested. This should solve the error.

It throws ConnectionRefusedError if it wasn't able to connect to the BitBox02 simulator, so we won't be able to use any other simulator.

As far as I saw, Trezor or Keepkey also call connect on their simulators without handling any exceptions or connect_ex. Do you have a suggestion how to handle this exactly?

As far as I saw, Trezor or Keepkey also call connect on their simulators without handling any exceptions or connect_ex.

See:

def enumerate(password: Optional[str] = None, expert: bool = False, chain: Chain = Chain.MAIN, allow_emulators: bool = False) -> List[Dict[str, Any]]:
    results = []
    devs = hid.HidTransport.enumerate()
    devs.extend(webusb.WebUsbTransport.enumerate())
    if allow_emulators:
        devs.extend(udp.UdpTransport.enumerate())
    for dev in devs:

When calling enumerate with --simulators, Trezor will call enumerate from UdpTransport. This function will return nothing if it wasn't able to find a device (simulator) so devs is empty.

Maybe you could do something like:

diff --git a/hwilib/devices/bitbox02.py b/hwilib/devices/bitbox02.py
index 53497c6..7cd6929 100644
--- a/hwilib/devices/bitbox02.py
+++ b/hwilib/devices/bitbox02.py
@@ -186,6 +186,8 @@ def enumerate(password: Optional[str] = None, expert: bool = False, chain: Chain
         devs.append(SIMULATOR_PATH)
     for path in devs:
         client = Bitbox02Client(path=path)
+        if allow_emulators and not client.transport:
+            continue
         if path != SIMULATOR_PATH:
             client.set_noise_config(SilentNoiseConfig())
         d_data: Dict[str, object] = {}
@@ -267,7 +269,11 @@ class BitBox02Simulator():
     def __init__(self) -> None:
         self.client_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
         ip, port = SIMULATOR_PATH.split(":")
-        self.client_socket.connect((ip, int(port)))
+        self.connected = True
+        try:
+            self.client_socket.connect((ip, int(port)))
+        except:
+            self.connected = False
 
     def write(self, data: bytes) -> None:
         # Messages from client are always prefixed with HID report ID(0x00), which is not expected by the simulator.
@@ -301,7 +307,10 @@ class Bitbox02Client(HardwareWalletClient):
             self.noise_config = CLINoiseConfig()
         else:
             simulator = BitBox02Simulator()
-            self.transport = u2fhid.U2FHid(simulator)
+            if simulator.connected:
+                self.transport = u2fhid.U2FHid(simulator)
+            else:
+                self.transport = None
         self.device_path = path
 
         # use self.init() to access self.bb02.

Okay, I did a fix based on this(not the same since this does not pass type checks). Now, in my tests, other devices are also passing the tests.